[webkit-reviews] review granted: [Bug 231221] Replace document.topDocument().securityOrigin() with document.topOrigin() : [Attachment 440185] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 5 02:29:28 PDT 2021
youenn fablet <youennf at gmail.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 231221: Replace document.topDocument().securityOrigin() with
document.topOrigin()
https://bugs.webkit.org/show_bug.cgi?id=231221
Attachment 440185: Patch
https://bugs.webkit.org/attachment.cgi?id=440185&action=review
--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 440185
--> https://bugs.webkit.org/attachment.cgi?id=440185
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=440185&action=review
> Source/WebCore/dom/DocumentStorageAccess.cpp:92
> + auto& topSecurityOrigin = m_document.topOrigin();
topSecurityOrigin is only used once, can we remove this variable?
> Source/WebCore/dom/DocumentStorageAccess.cpp:162
> + auto& topSecurityOrigin = m_document.topOrigin();
Ditto for both topSecurityOrigin and topDocument
More information about the webkit-reviews
mailing list