[webkit-reviews] review granted: [Bug 231209] CodeBlock should not add/remove LoopHintExecutionCounters. : [Attachment 440158] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 4 22:45:07 PDT 2021

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 231209: CodeBlock should not add/remove LoopHintExecutionCounters.

Attachment 440158: proposed patch.


--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 440158
  --> https://bugs.webkit.org/attachment.cgi?id=440158
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=440158&action=review


> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:144
> +    void finalize();

Suggestion: “finalize” has some common meaning in cells, typically meaning
doing some finalization work at the end of GC. Because of that, I’m not a fan
of this name. And right now, it’s only doing one very specific thing. I suggest
giving it a specific name to match the specific thing it’s doing.

More information about the webkit-reviews mailing list