[webkit-reviews] review granted: [Bug 229378] Shadertoy "truchet district" fails to compile with error: Internal error compiling shader with Metal backend" : [Attachment 440129] Patch

[bugzilla-daemon at webkit.org]

Jon Lee <jonlee at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 229378: Shadertoy "truchet district" fails to compile with error: Internal
error compiling shader with Metal backend"
https://bugs.webkit.org/show_bug.cgi?id=229378

Attachment 440129: Patch

https://bugs.webkit.org/attachment.cgi?id=440129&action=review




--- Comment #22 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 440129
  --> https://bugs.webkit.org/attachment.cgi?id=440129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440129&action=review

> Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect.cpp:-23
> -#include "compiler/translator/TranslatorMetalDirect/RewriteKeywords.h"

Is this file still used now? This seems to be the only file that uses the
now-removed function.

>
Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/Name.cpp:
72
> +	       out << mRawName;

include ASSERT() here also?

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:28
> +	   return N - 1;

nit: inconsistent tab spacing.