[webkit-reviews] review granted: [Bug 231160] Add an alternate style for form controls, and implement it for checkboxes and radio buttons : [Attachment 440119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 4 17:09:42 PDT 2021


Sam Weinig <sam at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 231160: Add an alternate style for form controls, and implement it for
checkboxes and radio buttons
https://bugs.webkit.org/show_bug.cgi?id=231160

Attachment 440119: Patch

https://bugs.webkit.org/attachment.cgi?id=440119&action=review




--- Comment #7 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 440119
  --> https://bugs.webkit.org/attachment.cgi?id=440119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440119&action=review

> Source/WebCore/rendering/RenderThemeIOS.h:117
>  #if ENABLE(IOS_FORM_CONTROL_REFRESH)

Got to rename / remove this soon? Just as soon as we rename
"modern-media-controls" right?

> Source/WebCore/rendering/RenderThemeIOS.mm:2070
> +	   // FIXME: The disabled state for the alternate appearance is
currently unspecified; this is just a guess.

Please make sure this has a bug.

> Source/WebCore/rendering/RenderThemeIOS.mm:2099
> +    gradient->addColorStop({ 1.0f, DisplayP3<float> { 0, 0, 0, 0 }});

Using DisplayP3 for these seem unnecessary (especially for the one that can use
Color::transparentBlack), but you do you.


More information about the webkit-reviews mailing list