[webkit-reviews] review granted: [Bug 231190] [ews-build.webkit.org] check-patch-relevance can get stuck : [Attachment 440105] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 16:27:37 PDT 2021
Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 231190: [ews-build.webkit.org] check-patch-relevance can get stuck
https://bugs.webkit.org/show_bug.cgi?id=231190
Attachment 440105: Patch
https://bugs.webkit.org/attachment.cgi?id=440105&action=review
--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 440105
--> https://bugs.webkit.org/attachment.cgi?id=440105
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=440105&action=review
> Tools/CISupport/ews-build/steps.py:399
> + bindings_regexes = [
I think that the new name doesn't describe the variable well. Either
bindings_paths or bindings_path_regexes would be better in my opinion.
Same comment for all the others below.
> Tools/CISupport/ews-build/steps.py:471
> + if regex.search(change[:250]):
[:250] doesn't appear to be explained, and I don't think that it's even
accurate to only look at the first 250 characters (.*jsc.* could be anywhere).
More information about the webkit-reviews
mailing list