[webkit-reviews] review granted: [Bug 231196] [Build-time perf] Forward declare JS TypedArrays : [Attachment 440116] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 4 16:12:48 PDT 2021


Tim Horton <thorton at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 231196: [Build-time perf] Forward declare JS TypedArrays
https://bugs.webkit.org/show_bug.cgi?id=231196

Attachment 440116: Patch

https://bugs.webkit.org/attachment.cgi?id=440116&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 440116
  --> https://bugs.webkit.org/attachment.cgi?id=440116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440116&action=review

Seems a bit red, might need some iteration

> Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeys.cpp:32
> +#include <JavaScriptCore/Uint8Array.h>
>  #include "HTMLMediaElement.h"

I think you've got this in the wrong place


More information about the webkit-reviews mailing list