[webkit-reviews] review granted: [Bug 230873] Incorrect Length constructor used after blending negative Length : [Attachment 440076] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 14:21:40 PDT 2021
Antoine Quint <graouts at webkit.org> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 230873: Incorrect Length constructor used after blending negative Length
https://bugs.webkit.org/show_bug.cgi?id=230873
Attachment 440076: Patch
https://bugs.webkit.org/attachment.cgi?id=440076&action=review
--- Comment #5 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 440076
--> https://bugs.webkit.org/attachment.cgi?id=440076
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=440076&action=review
> Source/WebCore/platform/Length.cpp:344
> + LengthType type = from.isZero() ? to.type() : from.type();
You can use `auto` here.
> Source/WebCore/style/StyleBuilderConverter.h:321
> + Length length = value.computeLength<Length>(conversionData);
You can use `auto` here.
More information about the webkit-reviews
mailing list