[webkit-reviews] review granted: [Bug 230388] radial-gradient does not accept calc values that combine length and percent : [Attachment 440090] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 230388: radial-gradient does not accept calc values that combine length and
percent
https://bugs.webkit.org/show_bug.cgi?id=230388

Attachment 440090: Patch

https://bugs.webkit.org/attachment.cgi?id=440090&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 440090
  --> https://bugs.webkit.org/attachment.cgi?id=440090
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440090&action=review

> LayoutTests/css3/calc/css3-radial-gradients.html:52
> +    background-image: radial-gradient(50px calc(50% + 10px), #f0f, #fff);

You should probably add another test with the simple radial-gradient(50px, 25%)
case that doesn't' involve calc.