[webkit-reviews] review granted: [Bug 231140] Use ScrollClamping in more places in scrolling code : [Attachment 440010] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 231140: Use ScrollClamping in more places in scrolling code
https://bugs.webkit.org/show_bug.cgi?id=231140

Attachment 440010: Patch

https://bugs.webkit.org/attachment.cgi?id=440010&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 440010
  --> https://bugs.webkit.org/attachment.cgi?id=440010
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440010&action=review

> Source/WebCore/platform/ScrollableArea.h:400
> -    unsigned m_constrainsScrollingToContentEdge : 1;
> +    unsigned m_scrollClamping : 1; // ScrollClamping
>  
>      unsigned m_inLiveResize : 1;

These should be regular typed fields instead of bitfields. We don't have enough
ScrollAreas for its size to matter.

They should then be initialized here instead of constructor.