[webkit-reviews] review granted: [Bug 231096] Enable PCM debug mode per WebsiteDataStore instead of process-global : [Attachment 439977] Patch

[bugzilla-daemon at webkit.org]

Kate Cheney <katherine_cheney at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 231096: Enable PCM debug mode per WebsiteDataStore instead of
process-global
https://bugs.webkit.org/show_bug.cgi?id=231096

Attachment 439977: Patch

https://bugs.webkit.org/attachment.cgi?id=439977&action=review




--- Comment #3 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 439977
  --> https://bugs.webkit.org/attachment.cgi?id=439977
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439977&action=review

LGTM

> Source/WebKit/NetworkProcess/NetworkSession.cpp:431
> +    auto message = enabled ? "[Private Click Measurement] Turned Debug Mode
on."_s : "[Private Click Measurement] Turned Debug Mode off."_s;

Seems like there was an isEphemeral() check in the previous code that got lost
here, not sure how important that is.