[webkit-reviews] review granted: [Bug 230929] Nullptr deref when accessing m_value.calc in CSSPrimitiveValue::primitiveType() : [Attachment 439936] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 230929: Nullptr deref when accessing m_value.calc in
CSSPrimitiveValue::primitiveType()
https://bugs.webkit.org/show_bug.cgi?id=230929

Attachment 439936: Patch

https://bugs.webkit.org/attachment.cgi?id=439936&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 439936
  --> https://bugs.webkit.org/attachment.cgi?id=439936
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439936&action=review

> Source/WebCore/css/CSSPrimitiveValue.cpp:435
> +    // TODO(webrtc:231111): this init should take Ref<CSSCalcValue> instead

This comment is not yet the right format for WebKit coding style:

1) We use FIXME, not TODO.
2) Not sure what "webrtc:" is about, OK to put a bug number in though.
3) We use sentence style, with a capital letter at the start, and a period at
the end.