[webkit-reviews] review granted: [Bug 231044] Allow NaN, infinity, and -infinity in calc : [Attachment 439924] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 231044: Allow NaN, infinity, and -infinity in calc
https://bugs.webkit.org/show_bug.cgi?id=231044

Attachment 439924: Patch

https://bugs.webkit.org/attachment.cgi?id=439924&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 439924
  --> https://bugs.webkit.org/attachment.cgi?id=439924
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439924&action=review

> Source/WebCore/css/calc/CSSCalcExpressionNodeParser.cpp:103
> +    return { { CSSValuePi, CSSUnitType::CSS_NUMBER, piDouble }, { CSSValueE,
CSSUnitType::CSS_NUMBER, std::exp(1.0) },
> +	   { CSSValueNegativeInfinity, CSSUnitType::CSS_NUMBER, -1 *
std::numeric_limits<double>::infinity() },
> +	   { CSSValueInfinity, CSSUnitType::CSS_NUMBER,
std::numeric_limits<double>::infinity() },
> +	   { CSSValueNaN, CSSUnitType::CSS_NUMBER,
std::numeric_limits<double>::quiet_NaN() } };

I would wrap this like:

return {
    { CSSValuePi, CSSUnitType::CSS_NUMBER, piDouble }, { CSSValueE,
CSSUnitType::CSS_NUMBER, std::exp(1.0) },
    { CSSValueNegativeInfinity, CSSUnitType::CSS_NUMBER, -1 *
std::numeric_limits<double>::infinity() },
    { CSSValueInfinity, CSSUnitType::CSS_NUMBER,
std::numeric_limits<double>::infinity() },
    { CSSValueNaN, CSSUnitType::CSS_NUMBER,
std::numeric_limits<double>::quiet_NaN() },
};