[webkit-reviews] review granted: [Bug 231085] Drop support for macOS < 10.15 : [Attachment 439899] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 231085: Drop support for macOS < 10.15
https://bugs.webkit.org/show_bug.cgi?id=231085

Attachment 439899: Patch

https://bugs.webkit.org/attachment.cgi?id=439899&action=review




--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 439899
  --> https://bugs.webkit.org/attachment.cgi?id=439899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439899&action=review

> Source/JavaScriptCore/API/JSValue.h:-556
> -#if (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) &&
__MAC_OS_X_VERSION_MIN_REQUIRED < 101500) ||
(defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED
< 130000)
> -typedef NSString *JSValueProperty;
> -#else
>  typedef id JSValueProperty;
> -#endif

I asked you this before and you didn’t respond:

Is it OK to make this change in a public SDK header? Maybe we still support
targeting these older versions with this header even if WebKit *code* no longer
supports them?

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:805
>	   if (shouldComputePhysicalTraits == ShouldComputePhysicalTraits::Yes)
{

Remove braces because this is now one line?

> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:41
> +#if PLATFORM(MAC)

Is this file used on iOS family at all?

> Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:171
> +#if PLATFORM(MAC)

Same question.

> Tools/TestRunnerShared/spi/AppKitTestSPI.h:-33
> -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
>  #define HAVE_NSDRAGGINGITEM_INITWITHITEM 1
> -#endif

This is only used in 3 places; we should simply remove the #if in all 3.