[webkit-reviews] review granted: [Bug 230966] GC may not know about memory used by AudioBufferSourceNode's buffer : [Attachment 439743] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 230966: GC may not know about memory used by AudioBufferSourceNode's buffer
https://bugs.webkit.org/show_bug.cgi?id=230966

Attachment 439743: Patch

https://bugs.webkit.org/attachment.cgi?id=439743&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 439743
  --> https://bugs.webkit.org/attachment.cgi?id=439743
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439743&action=review

> Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:40
> +    visitor.addOpaqueRoot(wrapped().buffer());

I think this needs a comment. Normally we mark things so we can preserve custom
JavaScript property values on the wrapper, not so that garbage collection
understands memory use. So this is needed for a subtle reason that someone
might not understand.