[webkit-reviews] review granted: [Bug 231016] [Performance] Optimize RenderLayer::establishesTopLayer : [Attachment 439830] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 1 10:43:27 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted cathiechen
<cathiechen at igalia.com>'s request for review:
Bug 231016: [Performance] Optimize RenderLayer::establishesTopLayer
https://bugs.webkit.org/show_bug.cgi?id=231016

Attachment 439830: Patch

https://bugs.webkit.org/attachment.cgi?id=439830&action=review




--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 439830
  --> https://bugs.webkit.org/attachment.cgi?id=439830
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439830&action=review

> Source/WebCore/dom/Element.h:512
> +    static bool isInTopLayerOrBackdrop(const RenderStyle& style, const
Element* element)
> +    {
> +	   return (element && element->isInTopLayer()) || style.styleType() ==
PseudoId::Backdrop;
> +    }

I would make this an inline free function at the bottom of this header.


More information about the webkit-reviews mailing list