[webkit-reviews] review granted: [Bug 230803] [JSC][32bit] Fix build after unlinked baseline JIT (r283083) : [Attachment 439857] v4

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 230803: [JSC][32bit] Fix build after unlinked baseline JIT (r283083)
https://bugs.webkit.org/show_bug.cgi?id=230803

Attachment 439857: v4

https://bugs.webkit.org/attachment.cgi?id=439857&action=review




--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 439857
  --> https://bugs.webkit.org/attachment.cgi?id=439857
v4

View in context: https://bugs.webkit.org/attachment.cgi?id=439857&action=review

Seems like a good first step to get things building. r=me

> Source/JavaScriptCore/bytecode/CallLinkInfo.h:28
> +#include "CallFrameShuffleData.h"

why was this needed. Why didn't the forward declare work?

> Source/JavaScriptCore/jit/JITInlines.h:369
> +    UNUSED_PARAM(value);
> +    UNUSED_PARAM(bytecode);
> +    // FIXME.

I think this can just be:
emitValueProfilingSite(valueProfileFor(bytecode.metadata(m_profiledCodeBlock),
m_bytecodeIndex.checkpoint()), value);

> Source/JavaScriptCore/jit/JITOpcodes.cpp:1472
> +	   loadGlobalObject(resultRegs.payloadGPR()); // FIXME: need to move
the whole thing.

I think you just need:
move(TrustedImm32(CellTag), resultRegs.tagGPR())