[webkit-reviews] review granted: [Bug 231022] Regression (r283238)[ MacOS wk1 ] fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html is timing out : [Attachment 439836] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 231022: Regression (r283238)[ MacOS wk1 ]
fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html is
timing out
https://bugs.webkit.org/show_bug.cgi?id=231022

Attachment 439836: Patch

https://bugs.webkit.org/attachment.cgi?id=439836&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 439836
  --> https://bugs.webkit.org/attachment.cgi?id=439836
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439836&action=review

> Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h:81
> +

Unnecessary

> Source/WebCore/html/CanvasBase.h:146
> +    HashSet<CanvasDisplayBufferObserver*> m_displayBufferObservers;

Can we make these WeakHashSet by making CanvasDisplayBufferObserver a
CanMakeWeakPtr<>?

> Source/WebCore/html/HTMLCanvasElement.cpp:1062
> +	   // composited and thus doesn't need preparation. Unfortunately

I am not sure we have tests with detached canvas, that might be worth adding,
and making sure we match the spec or other browsers.