[webkit-reviews] review granted: [Bug 233670] Adjust a Live Text quirk so that it applies to YouTube image thumbnails : [Attachment 445489] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 17:20:20 PST 2021


Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 233670: Adjust a Live Text quirk so that it applies to YouTube image
thumbnails
https://bugs.webkit.org/show_bug.cgi?id=233670

Attachment 445489: Patch

https://bugs.webkit.org/attachment.cgi?id=445489&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 445489
  --> https://bugs.webkit.org/attachment.cgi?id=445489
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445489&action=review

rs=me

> Source/WebCore/page/Quirks.cpp:1461
> +    if (host.endsWith(".youtube.com") || host == "youtube.com")

I think we normally use `equalLettersIgnoringASCIICase` and
`endsWithIgnoringASCIICase` (or `convertToASCIILowercase` beforehand).


More information about the webkit-reviews mailing list