[webkit-reviews] review granted: [Bug 233620] AX: Support accessibility attributes for <model> : [Attachment 445476] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 16:00:48 PST 2021


Dean Jackson <dino at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 233620: AX: Support accessibility attributes for <model>
https://bugs.webkit.org/show_bug.cgi?id=233620

Attachment 445476: patch

https://bugs.webkit.org/attachment.cgi?id=445476&action=review




--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 445476
  --> https://bugs.webkit.org/attachment.cgi?id=445476
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445476&action=review

>
LayoutTests/platform/mac/accessibility/model-element-attributes-exepcted.txt:1
> +This tests model elements have basic accessibility support

There is a typo in this filename. "exepcted"

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1279
> +    return isImage() || isInputImage() || isNativeImage() || isCanvas() ||
isModel() || (node() && node()->hasTagName(imgTag));

You probably want to guard the model stuff here and elsewhere with #if
ENABLE(MODEL_ELEMENT)


More information about the webkit-reviews mailing list