[webkit-reviews] review granted: [Bug 232895] [css-values-4] Support `*vi` (inline) and `*vb` (block) viewport units : [Attachment 444446] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 232895: [css-values-4] Support `*vi` (inline) and `*vb` (block) viewport
units
https://bugs.webkit.org/show_bug.cgi?id=232895

Attachment 444446: Patch

https://bugs.webkit.org/attachment.cgi?id=444446&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 444446
  --> https://bugs.webkit.org/attachment.cgi?id=444446
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444446&action=review

> Source/WebCore/css/CSSPrimitiveValue.cpp:695
> +    const auto* rootElement = renderView.document().documentElement();
> +    if (!rootElement)
> +	   return 0;

This makes me think we should test these units in an SVG document (i.e. main
document is SVG).

> Tools/ChangeLog:3
> +	   [css-values-4] Support `*vi` (inline) and `*vb` (block) viewport
units

Can we write some WPT?