[webkit-reviews] review denied: [Bug 233598] SharedBuffer::createFromReadingFile should use WTF::FileSystem : [Attachment 445350] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 233598: SharedBuffer::createFromReadingFile should use WTF::FileSystem
https://bugs.webkit.org/show_bug.cgi?id=233598

Attachment 445350: Patch

https://bugs.webkit.org/attachment.cgi?id=445350&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 445350
  --> https://bugs.webkit.org/attachment.cgi?id=445350
Patch

Before this change, Cocoa Windows and Glib all do one function call to read
something with known size and Posix calls read inside a loop.  After this
change, everything except Cocoa calls read inside a loop.  I don't think that's
an improvement.