[webkit-reviews] review granted: [Bug 233602] Correct serialization error in _WKApplicationManifestIcon : [Attachment 445427] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 233602: Correct serialization error in _WKApplicationManifestIcon
https://bugs.webkit.org/show_bug.cgi?id=233602

Attachment 445427: Patch

https://bugs.webkit.org/attachment.cgi?id=445427&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 445427
  --> https://bugs.webkit.org/attachment.cgi?id=445427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445427&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:379
> +    EXPECT_FALSE(error);

NIT: `EXPECT_NULL`?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:382
> +    EXPECT_FALSE(error);

ditto (:379)