[webkit-reviews] review granted: [Bug 233601] html/semantics/forms/constraints/form-validation-validity-patternMismatch.html WPT test is failing : [Attachment 445417] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 233601:
html/semantics/forms/constraints/form-validation-validity-patternMismatch.html
WPT test is failing
https://bugs.webkit.org/show_bug.cgi?id=233601

Attachment 445417: Patch

https://bugs.webkit.org/attachment.cgi?id=445417&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 445417
  --> https://bugs.webkit.org/attachment.cgi?id=445417
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445417&action=review

> Source/WebCore/html/BaseTextInputType.cpp:46
> +    String pattern = makeString("^(?:", rawPattern, ")$");

I’d think we’d want to create and capture a single Yarr::RegularExpression and
re-use it to make the findMatching loop more efficient.