[webkit-reviews] review denied: [Bug 233495] [MSE][WPE] Parameterize maximum buffer size using the MSE_MAX_BUFFER_SIZE env var : [Attachment 445206] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 233495: [MSE][WPE] Parameterize maximum buffer size using the
MSE_MAX_BUFFER_SIZE env var
https://bugs.webkit.org/show_bug.cgi?id=233495

Attachment 445206: Patch

https://bugs.webkit.org/attachment.cgi?id=445206&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 445206
  --> https://bugs.webkit.org/attachment.cgi?id=445206
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445206&action=review

I think we should move this logic to a virtual method, maybe in
SourceBufferPrivate.

> Source/WebCore/html/MediaElementSession.cpp:946
> +    String s(getenv("MSE_MAX_BUFFER_SIZE"));

std::