[webkit-reviews] review granted: [Bug 233593] [JSC] slice should be aware of terminated excution exception : [Attachment 445332] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 233593: [JSC] slice should be aware of terminated excution exception
https://bugs.webkit.org/show_bug.cgi?id=233593

Attachment 445332: Patch

https://bugs.webkit.org/attachment.cgi?id=445332&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 445332
  --> https://bugs.webkit.org/attachment.cgi?id=445332
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445332&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +	   [JSC] slice should be aware of terminated excution exception

It’s called a TerminationException now.  Also, you had a typo in “excution”.

> Source/JavaScriptCore/ChangeLog:9
> +	   Since terminated execution exception can happen at any time,
assertNoException is wrong.

Ditto.	Please use “termination exception” instead.

> JSTests/ChangeLog:9
> +	   * stress/slice-terminated-execution-exception.js: Added.

I suggest renaming this to slice-termination-exception.js to match the new
naming.