[webkit-reviews] review granted: [Bug 233424] [JSC] Unify most Baseline ops between JSVALUE64 and JSVALUE32_64 : [Attachment 445093] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Geza Lore <glore at igalia.com>'s
request for review:
Bug 233424: [JSC] Unify most Baseline ops between JSVALUE64 and JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=233424

Attachment 445093: Patch

https://bugs.webkit.org/attachment.cgi?id=445093&action=review




--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 445093
  --> https://bugs.webkit.org/attachment.cgi?id=445093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445093&action=review

r=me

> Source/JavaScriptCore/jit/JIT.h:336
> +	   static inline constexpr bool is_profiled_op =
std::is_same_v<decltype(Op::Metadata::m_profile), ValueProfile>;

Rename it to isProfiledOp.