[webkit-reviews] review granted: [Bug 233539] [JSC] Add Intl.NumberFormat.formatRangeToParts : [Attachment 445249] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 233539: [JSC] Add Intl.NumberFormat.formatRangeToParts
https://bugs.webkit.org/show_bug.cgi?id=233539

Attachment 445249: Patch

https://bugs.webkit.org/attachment.cgi?id=445249&action=review




--- Comment #4 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 445249
  --> https://bugs.webkit.org/attachment.cgi?id=445249
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445249&action=review

r=me, very nice.

> Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:1511
> +	   auto partValue = jsSubstring(vm, formatted, field.m_range.begin(),
field.m_range.end() - field.m_range.begin());

Wonder if we should add a method to WTF::Range for this?