[webkit-reviews] review granted: [Bug 233583] Plumb raw platform scrolling deltas along in wheel events : [Attachment 445319] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 233583: Plumb raw platform scrolling deltas along in wheel events
https://bugs.webkit.org/show_bug.cgi?id=233583

Attachment 445319: Patch

https://bugs.webkit.org/attachment.cgi?id=445319&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 445319
  --> https://bugs.webkit.org/attachment.cgi?id=445319
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445319&action=review

> Source/WebKit/Shared/mac/WebEventFactory.mm:436
> +	   return {
WebCore::FloatSize(-IOHIDEventGetFloatValue(ioHIDEvent.get(),
kIOHIDEventFieldScrollX), -IOHIDEventGetFloatValue(ioHIDEvent.get(),
kIOHIDEventFieldScrollY)) };

Does the negation here mean that m_rawPlatformDelta has the same sign as
scrollingDelta?