[webkit-reviews] review granted: [Bug 233343] Add a basic heuristic for sizing text in image overlay blocks : [Attachment 444773] Fix unused param

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 11:17:42 PST 2021

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 233343: Add a basic heuristic for sizing text in image overlay blocks

Attachment 444773: Fix unused param


--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 444773
  --> https://bugs.webkit.org/attachment.cgi?id=444773
Fix unused param

View in context: https://bugs.webkit.org/attachment.cgi?id=444773&action=review

> Source/WebCore/dom/ImageOverlay.cpp:306
> +	   rootContainer->setTranslate(false);

Seems like a nontrivial behavior change that should be in its own patch?

> Source/WebCore/dom/ImageOverlay.cpp:536
> +	   document->updateLayoutIgnorePendingStylesheets();

Does the layout of the rest of the page affect these things at all? If they're
independently positioned and sized, isn't this a bit overkill? (but also maybe
necessary? I don't know)

More information about the webkit-reviews mailing list