[webkit-reviews] review granted: [Bug 218880] Serialize CSS <number> values with rounding, limited decimal precision, and no exponents per-spec : [Attachment 444994] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Matt Woodrow <m_woodrow at apple.com>'s
request for review:
Bug 218880: Serialize CSS <number> values with rounding, limited decimal
precision, and no exponents per-spec
https://bugs.webkit.org/show_bug.cgi?id=218880

Attachment 444994: Patch

https://bugs.webkit.org/attachment.cgi?id=444994&action=review




--- Comment #26 from Darin Adler <darin at apple.com> ---
Comment on attachment 444994
  --> https://bugs.webkit.org/attachment.cgi?id=444994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444994&action=review

> Source/WTF/wtf/dtoa.cpp:42
> +template<std::size_t N>
> +static inline void truncateTrailingZeros(std::array<char, N>& buffer,
double_conversion::StringBuilder& builder)

Seems wasteful to make this a template function; we do not want risk ending up
with two separate copies. Instead I suggest we change the buffer argument to be
a char* or char[].