[webkit-reviews] review granted: [Bug 233407] [Model] clean up compile-time flags and condition IDL methods behind them : [Attachment 445077] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 233407: [Model] clean up compile-time flags and condition IDL methods
behind them
https://bugs.webkit.org/show_bug.cgi?id=233407

Attachment 445077: Patch

https://bugs.webkit.org/attachment.cgi?id=445077&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 445077
  --> https://bugs.webkit.org/attachment.cgi?id=445077
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445077&action=review

> Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:58
> -#if ENABLE(ARKIT_INLINE_PREVIEW_IOS)
> +#if HAVE(ASV_INLINE_PREVIEW_IOS)

Should just remove this ifdef, it's a lie

> Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:95
> -#if ENABLE(ARKIT_INLINE_PREVIEW_IOS)
> +#if HAVE(ASV_INLINE_PREVIEW_IOS)

Should just remove this ifdef, it's a lie