[webkit-reviews] review granted: [Bug 233571] [JSC] GetTypedArrayLengthAsInt52 can get Array::Generic ArrayMode : [Attachment 445291] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 10:25:43 PST 2021

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 233571: [JSC] GetTypedArrayLengthAsInt52 can get Array::Generic ArrayMode

Attachment 445291: Patch


--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 445291
  --> https://bugs.webkit.org/attachment.cgi?id=445291

View in context: https://bugs.webkit.org/attachment.cgi?id=445291&action=review


> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5110
> +	   // If arrayMode is ForceExit, we do not compile it.

I suggest rephrasing this as "If arrayMode is ForceExit, we would not compile
this node and hence, should not have arrived here."

More information about the webkit-reviews mailing list