[webkit-reviews] review granted: [Bug 233431] [WebGPU] Provide default values for descriptor struct members : [Attachment 445017] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 233431: [WebGPU] Provide default values for descriptor struct members
https://bugs.webkit.org/show_bug.cgi?id=233431

Attachment 445017: Patch

https://bugs.webkit.org/attachment.cgi?id=445017&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 445017
  --> https://bugs.webkit.org/attachment.cgi?id=445017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445017&action=review

> Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassColorAttachment.h:41
> +    TextureView* resolveTarget { nullptr };

I'm not sure about the lifetime of this object, but we may consider making this
a WeakPtr.