[webkit-reviews] review granted: [Bug 233454] Make webpushd "fake registration for testing" much more complicated by adding a "mock app bundle" install : [Attachment 445115] EWS v4

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 233454: Make webpushd "fake registration for testing" much more complicated
by adding a "mock app bundle" install
https://bugs.webkit.org/show_bug.cgi?id=233454

Attachment 445115: EWS v4

https://bugs.webkit.org/attachment.cgi?id=445115&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 445115
  --> https://bugs.webkit.org/attachment.cgi?id=445115
EWS v4

View in context: https://bugs.webkit.org/attachment.cgi?id=445115&action=review

> Source/WebKit/webpushd/AppBundleRequest.h:55
> +    ClientConnection* m_connection;

Let's not store a raw pointer.	Can this be a WeakPtr?

> Source/WebKit/webpushd/MockAppBundleForTesting.mm:43
> +

extra space, could use =default;

> Source/WebKit/webpushd/PushAppBundle.h:34
> +enum class PushAppBundleExists {

: bool

> Source/WebKit/webpushd/PushAppBundle.h:39
> +enum class PushAppBundleCreationResult {

: bool