[webkit-reviews] review granted: [Bug 233415] [JSC] Move m_incomingPolymorphicCalls out of CodeBlock::JITData : [Attachment 444949] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 233415: [JSC] Move m_incomingPolymorphicCalls out of CodeBlock::JITData
https://bugs.webkit.org/show_bug.cgi?id=233415

Attachment 444949: Patch

https://bugs.webkit.org/attachment.cgi?id=444949&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 444949
  --> https://bugs.webkit.org/attachment.cgi?id=444949
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444949&action=review

Nice.  r=me

> Tools/TestWebKitAPI/Tests/WTF/SentinelLinkedList.cpp:96
> +

Can you add the following here?
    EXPECT_TRUE(!first->isOnList());
    EXPECT_TRUE(!second->isOnList());
    EXPECT_TRUE(!third->isOnList());
    EXPECT_TRUE(!fourth->isOnList());

> Tools/TestWebKitAPI/Tests/WTF/SentinelLinkedList.cpp:100
> +TEST(WTF_SentinelLinkedList, RemoveAll)

I think `Remove` is a better name for this test (instead of `RemoveAll`) since
it's testing the `remove` method.

> Tools/TestWebKitAPI/Tests/WTF/SentinelLinkedList.cpp:115
> +}

Can you add an `EXPECT_TRUE(i == 10);` here?