[webkit-reviews] review denied: [Bug 232618] Add a runtime flag to enable CSS Transforms Level 2 spec compliant behavior : [Attachment 443325] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 232618: Add a runtime flag to enable CSS Transforms Level 2 spec compliant
behavior
https://bugs.webkit.org/show_bug.cgi?id=232618

Attachment 443325: Patch

https://bugs.webkit.org/attachment.cgi?id=443325&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 443325
  --> https://bugs.webkit.org/attachment.cgi?id=443325
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443325&action=review

r- to switch to a setting.

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1325
> +  humanReadableDescription: "Enable Transforms Level 2 spec compliant
behavior that is backwards incompatble"

"incompatble".

I think we can come up with a better name/description. Maybe "CSS 3D Transform
Interoperability"?

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1326
> +  webcoreBinding: RuntimeEnabledFeatures

We don't use RuntimeEnabledFeatures any more.