[webkit-reviews] review granted: [Bug 52700] Transition from perspective(500px) to 'none' is probably wrong : [Attachment 443943] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 08:38:57 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 52700: Transition from perspective(500px) to 'none' is probably wrong
https://bugs.webkit.org/show_bug.cgi?id=52700

Attachment 443943: Patch

https://bugs.webkit.org/attachment.cgi?id=443943&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 443943
  --> https://bugs.webkit.org/attachment.cgi?id=443943
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443943&action=review

>
Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.cpp:5
9
> +	       const auto* fromOp =
> +		   downcast<PerspectiveTransformOperation>(from);

No wrapping.

>
Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.cpp:6
0
> +	       fromPInverse = !fromOp->isIdentity() ? (1.0 /
(*fromOp->floatValue())) : 0.0;

Since this is repeated, put it in a lambda.

>
Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h:63
> +	   return floatValueForLength(*m_p, 1.0);

Does m_p ever have calc() it in at this point?


More information about the webkit-reviews mailing list