[webkit-reviews] review granted: [Bug 232831] [GPU Process] [Filters 8/17] Implement FilterEffect CoreImage appliers : [Attachment 445211] Patch

[bugzilla-daemon at webkit.org]

Cameron McCormack (:heycam) <heycam at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 232831: [GPU Process] [Filters 8/17] Implement FilterEffect CoreImage
appliers
https://bugs.webkit.org/show_bug.cgi?id=232831

Attachment 445211: Patch

https://bugs.webkit.org/attachment.cgi?id=445211&action=review




--- Comment #3 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 445211
  --> https://bugs.webkit.org/attachment.cgi?id=445211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445211&action=review

> Source/WebCore/platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm:3
> +/*
> +* Copyright (C) 2020-2021 Apple Inc. All rights reserved.
> +*

This (and in the other added files in this patch) is copied from another file,
but the asterisks are misaligned.

> Source/WebCore/svg/graphics/filters/SVGFilter.cpp:91
> +bool SVGFilter::supportsCoreImageRendering() const
> +{

I notice that this and CSSFIlter::supportsCoreImageRendering() are very
similar, and that CSSFilter::m_functions and SVGFilter::m_expression are almost
the same type. Should we have a common implementation of
supportsCoreImageRendering() on Filter (or maybe you will move some CSSFilter
and SVGFilter commonality up to Filter in a later patch in your queue)?