[webkit-reviews] review granted: [Bug 233516] [GPU Process] [Filters 7.3/17] Make FilterEffects create FilterEffectAppliers which will be used by FilterEffect::apply() : [Attachment 445185] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 26 13:06:58 PST 2021
Cameron McCormack (:heycam) <heycam at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 233516: [GPU Process] [Filters 7.3/17] Make FilterEffects create
FilterEffectAppliers which will be used by FilterEffect::apply()
https://bugs.webkit.org/show_bug.cgi?id=233516
Attachment 445185: Patch
https://bugs.webkit.org/attachment.cgi?id=445185&action=review
--- Comment #2 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 445185
--> https://bugs.webkit.org/attachment.cgi?id=445185
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=445185&action=review
> Source/WebCore/platform/graphics/filters/FilterEffectApplier.h:37
> + template<typename FilterEffectApplierType, typename FilterEffectType>
> + static std::unique_ptr<FilterEffectApplierType> create(const
FilterEffectType& effect)
Is there a need to allocate FilterEffectAppliers on the heap? Currently we
don't let the applier object last longer than the function we create it in.
> Source/WebCore/platform/graphics/filters/FilterEffectApplier.h:42
> FilterEffectApplier() = default;
If we do keep creating unique_ptrs for filterEffectAppliers, should this be
private?
More information about the webkit-reviews
mailing list