[webkit-reviews] review denied: [Bug 233492] [GStreamer][WPE] Control on-disk multimedia buffering via the WPE_SHELL_DISABLE_MEDIA_DISK_CACHE environment variable : [Attachment 445136] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 26 03:27:41 PST 2021


Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 233492: [GStreamer][WPE] Control on-disk multimedia buffering via the
WPE_SHELL_DISABLE_MEDIA_DISK_CACHE environment variable
https://bugs.webkit.org/show_bug.cgi?id=233492

Attachment 445136: Patch

https://bugs.webkit.org/attachment.cgi?id=445136&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 445136
  --> https://bugs.webkit.org/attachment.cgi?id=445136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445136&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2565
> +    static bool computed = false;

Please, use std::once...


More information about the webkit-reviews mailing list