[webkit-reviews] review granted: [Bug 233452] [GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range : [Attachment 445051] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 23 15:50:47 PST 2021

Michael Catanzaro <mcatanzaro at gnome.org> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 233452: [GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range

Attachment 445051: Patch


--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 445051
  --> https://bugs.webkit.org/attachment.cgi?id=445051

View in context: https://bugs.webkit.org/attachment.cgi?id=445051&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:1336
>      window->backgroundColor.alpha = 1;

Nit: might as well write this as 1.0 as well, to be consistent with the line
above. Or write 1 in both places. Doesn't matter, of course....

More information about the webkit-reviews mailing list