[webkit-reviews] review granted: [Bug 232832] [GPU Process] [Filters 9/17] Move the software FilterEffect functions to separate applier classes : [Attachment 445048] Patch

[bugzilla-daemon at webkit.org]

Cameron McCormack (:heycam) <heycam at apple.com> has granted  review:
Bug 232832: [GPU Process] [Filters 9/17] Move the software FilterEffect
functions to separate applier classes
https://bugs.webkit.org/show_bug.cgi?id=232832

Attachment 445048: Patch

https://bugs.webkit.org/attachment.cgi?id=445048&action=review




--- Comment #14 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 445048
  --> https://bugs.webkit.org/attachment.cgi?id=445048
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445048&action=review

> Source/WebCore/ChangeLog:234
> +	   Move filing the structure LightingData from
FELighting::drawLighting()

"filling"

> Source/WebCore/platform/graphics/filters/FETurbulence.cpp:128
> +    static const int perlinNoise = 4096;
> +    static const long randMaximum = 2147483647; // 2**31 - 1
> +    static const int randAmplitude = 16807; // 7**5; primitive root of m
> +    static const int randQ = 127773; // m / a
> +    static const int randR = 2836; // m % a
> +
> +    static const int blockSize = 256;
> +    static const int blockMask = blockSize - 1;

Now that these are member variables again I guess they should get their "s_"
prefixes back! :/