[webkit-reviews] review granted: [Bug 233363] Remove unnecessary flattening of SharedBuffer when sending them over IPC : [Attachment 444854] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 233363: Remove unnecessary flattening of SharedBuffer when sending them
over IPC
https://bugs.webkit.org/show_bug.cgi?id=233363

Attachment 444854: Patch

https://bugs.webkit.org/attachment.cgi?id=444854&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 444854
  --> https://bugs.webkit.org/attachment.cgi?id=444854
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444854&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2668
>	       auto buffer = SharedBuffer::create(data);
> +	       auto sharedMemory = SharedMemory::copyBuffer(buffer.get());
> +	       if (!sharedMemory)
> +		   continue;

Would be nice to avoid the SharedBuffer allocation here also at some point by
adding something like a SharedMemory::copyBuffer() that took a Span.