[webkit-reviews] review granted: [Bug 232624] [JSC] Make sharing of unlinked baseline code possible on JSVALUE32_64 : [Attachment 444242] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Geza Lore <glore at igalia.com>'s
request for review:
Bug 232624: [JSC] Make sharing of unlinked baseline code possible on
JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=232624

Attachment 444242: Patch

https://bugs.webkit.org/attachment.cgi?id=444242&action=review




--- Comment #10 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 444242
  --> https://bugs.webkit.org/attachment.cgi?id=444242
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444242&action=review

r=me

> Source/JavaScriptCore/jit/AssemblyHelpers.h:284
> +#elif USE(JSVALUE32_64)

There is no other config, so you can just use "#else"

> Source/JavaScriptCore/jit/AssemblyHelpers.h:1080
> +#elif USE(JSVALUE32_64)

Ditto.

> Source/JavaScriptCore/jit/AssemblyHelpers.h:1089
> +#elif USE(JSVALUE32_64)

Ditto.

> Source/JavaScriptCore/jit/AssemblyHelpers.h:1168
> +#elif USE(JSVALUE32_64)

Ditto.