[webkit-reviews] review granted: [Bug 233144] Integrate motion path transforms in transformation pipeline : [Attachment 444816] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kiet Ho <tho22 at apple.com>'s request
for review:
Bug 233144: Integrate motion path transforms in transformation pipeline
https://bugs.webkit.org/show_bug.cgi?id=233144

Attachment 444816: Patch

https://bugs.webkit.org/attachment.cgi?id=444816&action=review




--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 444816
  --> https://bugs.webkit.org/attachment.cgi?id=444816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444816&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:1468
> +    // FIXME: support Reference and Box type.

Can you file a bugzilla for this and mention it here?

> Source/WebCore/rendering/style/RenderStyle.cpp:1505
> +    // Default value of offset-anchor is transform-origin

Nit: This comment should end with a period. However, I don't think you need the
comment anyway :)

> Source/WebCore/rendering/style/RenderStyle.cpp:1507
> +    // Handle the case if offset-anchor is not auto

Same with this. The comment isn't necessary.