[webkit-reviews] review granted: [Bug 233349] Web Inspector: Console execution context can become an unexpected selection on refresh/navigation : [Attachment 444767] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 233349: Web Inspector: Console execution context can become an unexpected
selection on refresh/navigation
https://bugs.webkit.org/show_bug.cgi?id=233349

Attachment 444767: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=444767&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 444767
  --> https://bugs.webkit.org/attachment.cgi?id=444767
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=444767&action=review

r=me, nice catch :)

> Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:400
>		   this._restoreSelectedExecutionContextForFrame = null;

Style: I'd add a newline after this

> Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:401
> +		   this._useExecutionContextOfInspectedNode =
InspectorBackend.hasDomain("DOM");

NIT: We should probably make a `_canUseExecutionContextOfInspectedNode()` or
something since this is done so often.