[webkit-reviews] review granted: [Bug 233365] [Model] add audio support : [Attachment 444817] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 233365: [Model] add audio support
https://bugs.webkit.org/show_bug.cgi?id=233365

Attachment 444817: Patch

https://bugs.webkit.org/attachment.cgi?id=444817&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 444817
  --> https://bugs.webkit.org/attachment.cgi?id=444817
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444817&action=review

> Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:160
> +    auto* strongPage = m_page.get();

This should either be `RefPtr strongPage = m_page.get();`, or we shouldn't call
it `strongPage`.

> Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:186
> +    auto* strongPage = m_page.get();

(Ditto)

> Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:212
> +    auto* strongPage = m_page.get();

(Ditto)