[webkit-reviews] review granted: [Bug 233350] Add support for web app manifest icons in WebKit/UI Process layer : [Attachment 444775] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 233350: Add support for web app manifest icons in WebKit/UI Process layer
https://bugs.webkit.org/show_bug.cgi?id=233350

Attachment 444775: Patch

https://bugs.webkit.org/attachment.cgi?id=444775&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 444775
  --> https://bugs.webkit.org/attachment.cgi?id=444775
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444775&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm:56
> +static NSArray<NSNumber *> *fromPurposes(const
OptionSet<WebCore::ApplicationManifest::Icon::Purpose>& purposes)

An OptionSet is just an integer, we should pass it by value.

Also, this function should probably return a RetainPtr<NSArray<NSNumber *>>.
The call site can call .autorelease() if needed.

> Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:168
> +	   EXPECT_TRUE(testIndex < value.size());

Could use EXPECT_LT()