[webkit-reviews] review granted: [Bug 228105] [css-grid] svg image as grid items should use the overriding logical width/height when defined to compute the logical height/width : [Attachment 444665] Patch

[bugzilla-daemon at webkit.org]

Javier Fernandez <jfernandez at igalia.com> has granted zsun at igalia.com's request
for review:
Bug 228105: [css-grid] svg image as grid items should use the overriding
logical width/height when defined to compute the logical height/width
https://bugs.webkit.org/show_bug.cgi?id=228105

Attachment 444665: Patch

https://bugs.webkit.org/attachment.cgi?id=444665&action=review




--- Comment #12 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 444665
  --> https://bugs.webkit.org/attachment.cgi?id=444665
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444665&action=review

r=me

> Source/WebCore/rendering/RenderReplaced.cpp:534
> +static inline bool hasIntrinsicSize(RenderBox*contentRenderer, bool
hasIntrinsicWidth, bool hasIntrinsicHeight )

nit: s/*contentRender/* contentRender

> Source/WebCore/rendering/RenderReplaced.cpp:538
> +    if (contentRenderer && contentRenderer->isSVGRoot() &&
(hasIntrinsicWidth || hasIntrinsicHeight))

Just a suggestion; what about doing this like:

if (hasIntrinsicWidth || hasIntrinsicHeight))
  return contentRenderer && contentRenderer->isSVGRoot()

The idea is to make clear that we only consider single-axis size as intrinsic
in the case of SVG root. For any other case we would expect both, width and
height to be intrinsic.