[webkit-reviews] review granted: [Bug 233295] More webpushd architecture work : [Attachment 444760] Updated for review feedback, still building locally to explore Mac API test failure

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 233295: More webpushd architecture work
https://bugs.webkit.org/show_bug.cgi?id=233295

Attachment 444760: Updated for review feedback, still building locally to
explore Mac API test failure

https://bugs.webkit.org/attachment.cgi?id=444760&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 444760
  --> https://bugs.webkit.org/attachment.cgi?id=444760
Updated for review feedback, still building locally to explore Mac API test
failure

View in context: https://bugs.webkit.org/attachment.cgi?id=444760&action=review

> Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp:39
>  NetworkNotificationManager::NetworkNotificationManager(NetworkSession&
networkSession, const String& webPushMachServiceName)

nit: mach service names can be a CString because they are always ASCII.

> Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp:53
> +	  
sendMessage<WebPushD::MessageType::SetHostAppAuditToken>(auditTokenData);

Sending the first message will start the daemon if it hasn't been started, so
we probably want to lazily send this to prevent unnecessary daemon starting.

> Source/WebKit/webpushd/PushClientConnection.h:44
> +    String hostAppCodeSigningIdentifier();

nit: can this return a const String& ?